docs: add project status section + fix(ios): main-thread AVAudioEngine access#29
Closed
txbrown wants to merge 3 commits into
Closed
docs: add project status section + fix(ios): main-thread AVAudioEngine access#29txbrown wants to merge 3 commits into
txbrown wants to merge 3 commits into
Conversation
- Add alpha status badge - Document supported platforms and features - List known issues with links to tracker Closes #21
AVAudioEngine.outputNode must be accessed on the main thread to avoid an RPC timeout in AURemoteIO::Cleanup when called from a background queue. Wrap getAudioInfo, getSampleRate, loadAudioResource, and unloadAudioResource in dispatch_async(dispatch_get_main_queue()). applyInstructions and setProperty are left as-is since they are performance-critical and only hit the AV engine on first call (subsequent calls take the audioEngineInitialized fast path). Patch insight from midicircuit-rn.
txbrown
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes on the engine-lifecycle branch:
1. README project status section (closes #21)
2. iOS main-thread AVAudioEngine access (partially addresses #15)
AVAudioEngine.outputNodemust be accessed on the main thread to avoid RPC timeoutsgetAudioInfo,getSampleRate,loadAudioResource,unloadAudioResourceindispatch_async(dispatch_get_main_queue())applyInstructionsandsetPropertyleft as-is (perf-critical, only hit AV engine on first call)Remaining from #15