fix: 修复几个编译期和运行时的 bug - #41
Merged
Merged
Conversation
by965738071
commented
Jun 26, 2026
by965738071
commented
Contributor
- pool.zig: full() 里 self.list 写错了，应该是 self.items
- runtime/lib.zig: 删掉不存在的 Timespec 导入，编译会报错
- storage.zig: deinit 改成接收 *Storage 指针，别用值拷贝
- lib.zig: 线程 spawn 失败时打日志，之前直接 catch return 静默吞掉错误会导致其他线程死等
- pool.zig: full() 里 self.list 写错了，应该是 self.items - runtime/lib.zig: 删掉不存在的 Timespec 导入，编译会报错 - storage.zig: deinit 改成接收 *Storage 指针，别用值拷贝 - lib.zig: 线程 spawn 失败时打日志，之前直接 catch return 静默吞掉错误会导致其他线程死等
Collaborator
|
Looks good to me, thanks. |
Collaborator
|
I have updated main branch to use the latest dev release of Zig, so checks won't pass. Are using Zig dev or 0.16.x? If you are using 0.16.x then I could cherry-pick these changes into zig-0.16.x and make a patch release so that you can use that, or else enjoy dev. |
Contributor
Author
|
Latest Zig code. zig-0.17-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.