Skip to content

Send sync2#1736

Open
sftse wants to merge 5 commits into
tauri-apps:devfrom
sftse:send-sync2
Open

Send sync2#1736
sftse wants to merge 5 commits into
tauri-apps:devfrom
sftse:send-sync2

Conversation

@sftse
Copy link
Copy Markdown
Contributor

@sftse sftse commented May 24, 2026

Partially superseding #1571, I'll take another look at that PR shortly, hadn't seen it no longer applies cleanly.

When we backtracked on the handler needing to be Send/Sync, NewWindowOpener can now also lose its unsafe override.

@sftse sftse requested a review from a team as a code owner May 24, 2026 10:54
@github-actions
Copy link
Copy Markdown
Contributor

Package Changes Through e8d68b4

There are 1 changes which include wry with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.55.1 0.56.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Legend-Master
Legend-Master previously approved these changes May 24, 2026
Copy link
Copy Markdown
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just a small nitpick

And you need to sign your commits

Comment thread src/android/binding.rs Outdated
Comment thread src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants