Prefer Class-File API on Java 24 or above#391
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
============================================
+ Coverage 79.07% 81.43% +2.35%
Complexity 72 72
============================================
Files 6 6
Lines 239 237 -2
Branches 27 27
============================================
+ Hits 189 193 +4
+ Misses 37 31 -6
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the contribution - but we cannot just increase the minimum java version to 24 or even 25. |
|
See #383 (comment). |
Yeah, but the PR is just on main. We would need a strategy how to handle this. |
|
There could be 2 branches for maintaining, v2 and v3, e.g. https://github.com/GradleUp/shadow
|
|
Alternatively, we can provide a multi-release jar. See JakeWharton/diffuse#477. |
6b4a34b to
e25eda7
Compare
e25eda7 to
54a593f
Compare
54a593f to
47d9554
Compare
Closes #383.