Skip to content

Prefer Class-File API on Java 24 or above#391

Open
Goooler wants to merge 1 commit into
tcurdt:masterfrom
Goooler:migrate-to-class-file-api
Open

Prefer Class-File API on Java 24 or above#391
Goooler wants to merge 1 commit into
tcurdt:masterfrom
Goooler:migrate-to-class-file-api

Conversation

@Goooler

@Goooler Goooler commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Closes #383.

@codecov-commenter

codecov-commenter commented Feb 25, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.43%. Comparing base (bac5a57) to head (47d9554).
⚠️ Report is 198 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #391      +/-   ##
============================================
+ Coverage     79.07%   81.43%   +2.35%     
  Complexity       72       72              
============================================
  Files             6        6              
  Lines           239      237       -2     
  Branches         27       27              
============================================
+ Hits            189      193       +4     
+ Misses           37       31       -6     
  Partials         13       13              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tcurdt

tcurdt commented Feb 25, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution - but we cannot just increase the minimum java version to 24 or even 25.

@Goooler

Goooler commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

See #383 (comment).

@tcurdt

tcurdt commented Feb 25, 2026

Copy link
Copy Markdown
Owner

See #383 (comment).

Yeah, but the PR is just on main. We would need a strategy how to handle this.
Maintaining two separate versions - I am not so eager.

@Goooler

Goooler commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

There could be 2 branches for maintaining, v2 and v3, e.g. https://github.com/GradleUp/shadow

  • main for v9
  • 8.x for v8

@Goooler

Goooler commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Alternatively, we can provide a multi-release jar. See JakeWharton/diffuse#477.

@Goooler Goooler force-pushed the migrate-to-class-file-api branch from 6b4a34b to e25eda7 Compare June 13, 2026 11:05
@Goooler Goooler changed the title Migrate from ASM to Class-File API Prefer Class-File API on Java 24 or above Jun 13, 2026
@Goooler Goooler force-pushed the migrate-to-class-file-api branch from e25eda7 to 54a593f Compare June 13, 2026 11:12
@Goooler Goooler force-pushed the migrate-to-class-file-api branch from 54a593f to 47d9554 Compare June 13, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from ASM to Class-File API

3 participants