Feat: Console Plugin Image should be picked conditionally based OCP Version#3386
Open
pramodbindal wants to merge 1 commit intotektoncd:mainfrom
Open
Feat: Console Plugin Image should be picked conditionally based OCP Version#3386pramodbindal wants to merge 1 commit intotektoncd:mainfrom
pramodbindal wants to merge 1 commit intotektoncd:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jkhelil
reviewed
Apr 30, 2026
| if err != nil { | ||
| cpr.logger.Error("error getting OCP version", "err", err) | ||
| } | ||
| if ocpVersion.Major() == 4 && ocpVersion.Minor() < 22 { |
Member
There was a problem hiding this comment.
ocpVersion may be nil here if err != nil , which will panic
Member
Author
There was a problem hiding this comment.
versionStr := cv.Status.Desired.Version
if versionStr == "" {
return nil, fmt.Errorf("empty OpenShift version in ClusterVersion status")
}
As per this logic if version is missing then it will throw error.
jkhelil
reviewed
Apr 30, 2026
jkhelil
reviewed
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes