Skip to content

Feat: Console Plugin Image should be picked conditionally based OCP Version#3386

Open
pramodbindal wants to merge 1 commit intotektoncd:mainfrom
tektoncd-pb:ocp-pf5
Open

Feat: Console Plugin Image should be picked conditionally based OCP Version#3386
pramodbindal wants to merge 1 commit intotektoncd:mainfrom
tektoncd-pb:ocp-pf5

Conversation

@pramodbindal
Copy link
Copy Markdown
Member

Changes

  1. Introduce a new function to read the clusterVersion from OCP
  2. ConsolePlugin image is picked based on OCPVersion. for OCP Versions older than 4.22 legacy image us picked while for newer OCP version image key remain unchanged.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Added support for conditionally picking the console-plugin image on openshift.
OCP version older than 4.22 pick the legacy console plugin
Newer version pick the last console plugin image

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 30, 2026
@tekton-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pramodbindal after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2026
if err != nil {
cpr.logger.Error("error getting OCP version", "err", err)
}
if ocpVersion.Major() == 4 && ocpVersion.Minor() < 22 {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocpVersion may be nil here if err != nil , which will panic

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionStr := cv.Status.Desired.Version
	if versionStr == "" {
		return nil, fmt.Errorf("empty OpenShift version in ClusterVersion status")
	}

As per this logic if version is missing then it will throw error.

Comment thread pkg/reconciler/openshift/common/common_utils.go
Comment thread pkg/reconciler/openshift/common/common_utils.go
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants