Skip to content

Add system Nexus WIT operation metadata#783

Open
tconley1428 wants to merge 17 commits into
mainfrom
system-nexus-wit
Open

Add system Nexus WIT operation metadata#783
tconley1428 wants to merge 17 commits into
mainfrom
system-nexus-wit

Conversation

@tconley1428
Copy link
Copy Markdown
Contributor

@tconley1428 tconley1428 commented May 20, 2026

What changed

  • Adds generation step for producing/updating WIT files for exposed API definitions.
  • Documents that Rust is required when running make because system Nexus WIT generation installs and runs nexus-api-gen.

@tconley1428 tconley1428 marked this pull request as ready for review June 3, 2026 23:30
@tconley1428 tconley1428 requested review from a team June 3, 2026 23:30
Comment thread nexus/workflow-service.wit Outdated
@Sushisource
Copy link
Copy Markdown
Member

Is this PR gonna have the check that new things were added or is that a follow up PR?

@tconley1428
Copy link
Copy Markdown
Contributor Author

It already does! The API repo already checks for any dirty diff after the makefile build.

@Sushisource
Copy link
Copy Markdown
Member

It already does! The API repo already checks for any dirty diff after the makefile build.

Aaaa, how about that then. Nice. What about manual changes to the output though? Isn't it going to complain about a diff there and we need some way to indicate it's OK?

@tconley1428
Copy link
Copy Markdown
Contributor Author

The make command actually does a merge operation into the output rather than fully regenerating. It will leave customizations in place. There might be some teething with that but it has been working so far.

@tconley1428
Copy link
Copy Markdown
Contributor Author

You can tell by the fact that this heavily customized output is not failing the diff check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants