Add client-authority support to config profile settings#1084
Open
NasitSony wants to merge 3 commits into
Open
Conversation
Convert SearchAttributes using CustomJSONMarshalOptions before assigning to printableSchedule, ensuring typed fields serialize correctly through standard json.Marshal. Fixes temporalio#590
Wire ClientAuthority flag into the envconfig ClientConfigProfile so it can be set via 'temporal config set --prop client-authority'. Also updates DefaultConfigFilePath() call sites to handle the updated signature in envconfig v1.0.2 which now returns a single string instead of (string, error). Fixes temporalio#1013
Wire ClientAuthority flag into envconfig ClientConfigProfile so it can be set and retrieved via 'temporal config set/get': temporal config set --prop client-authority --value my-authority temporal config get --prop client-authority Changes: - Add 'authority' to envConfigPropsToFieldNames map in commands.config.go - Wire cfg.ClientAuthority to profile.Authority in client.go - Update DefaultConfigFilePath() call sites for envconfig v1.0.2 signature change (string instead of string, error) - Bump go.temporal.io/sdk/contrib/envconfig to v1.0.2 - Add authority field to config tests Fixes temporalio#1013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #1013
What changed?
authoritytoenvConfigPropsToFieldNamesmap soclient-authoritycan be get/set via config commandscfg.ClientAuthoritytoprofile.Authorityinclient.goDefaultConfigFilePath()call sites for envconfig v1.0.2signature change (returns
stringinstead of(string, error))go.temporal.io/sdk/contrib/envconfigto v1.0.2authorityfield to config testsChecklist
Stability
Design
Tests
Manual tests
Setup
Happy path
Error case