Skip to content

upgrade on CAN#1316

Merged
THardy98 merged 5 commits into
mainfrom
feat/upgrade-on-can
Jun 9, 2026
Merged

upgrade on CAN#1316
THardy98 merged 5 commits into
mainfrom
feat/upgrade-on-can

Conversation

@THardy98

@THardy98 THardy98 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What was changed

Add trampolining (upgrade on CAN) to Rust SDK

Why?

Last SDK needed before we can go GA

  1. How was this tested:
    Integration tests

@THardy98 THardy98 force-pushed the feat/upgrade-on-can branch 2 times, most recently from 988b044 to 44d1d8e Compare June 8, 2026 16:07
@THardy98 THardy98 force-pushed the feat/upgrade-on-can branch from 44d1d8e to 941d45f Compare June 8, 2026 18:59
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Opengrep — new findings

Severity Location Rule Message
ERROR crates/protos/protos/api_upstream/.github/workflows/create-release.yml:25 security.gha.missing-explicit-permissions-temporal No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).
ERROR crates/protos/protos/api_upstream/.github/workflows/create-release.yml:30 security.gha.missing-explicit-permissions-temporal No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).
ERROR crates/protos/protos/api_upstream/.github/workflows/create-release.yml:99 security.gha.missing-explicit-permissions-temporal No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).
ERROR crates/protos/protos/api_upstream/.github/workflows/trigger-api-go-update.yml:16 security.gha.missing-explicit-permissions-temporal No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

Suppress findings

Add a noopengrep comment on the line before the finding:

# noopengrep: <rule-id>

@THardy98 THardy98 marked this pull request as ready for review June 8, 2026 19:12
@THardy98 THardy98 requested a review from a team as a code owner June 8, 2026 19:12
Comment thread .cargo/config.toml
Comment thread crates/sdk-core/tests/integ_tests/worker_versioning_tests.rs Outdated
@THardy98 THardy98 force-pushed the feat/upgrade-on-can branch from 314d5b3 to 55e8033 Compare June 9, 2026 02:35
@THardy98 THardy98 requested a review from Sushisource June 9, 2026 12:51
Comment thread crates/sdk/src/lib.rs Outdated

@chris-olszewski chris-olszewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only feedback is avoiding the direct proto type.

Comment thread crates/sdk/src/lib.rs Outdated
Comment thread crates/workflow/src/workflow_context/options.rs
Comment thread crates/sdk/src/lib.rs Outdated
Comment thread crates/sdk-core/tests/integ_tests/worker_versioning_tests.rs
@THardy98 THardy98 requested a review from chris-olszewski June 9, 2026 20:37
@THardy98 THardy98 merged commit 7d8d61f into main Jun 9, 2026
23 checks passed
@THardy98 THardy98 deleted the feat/upgrade-on-can branch June 9, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants