feat: add Temporal Rust SDK references#235
Conversation
|
|
|
Hey, fantastic, thanks for putting this PR up! Will definitely take a look! |
|
Hey @donald-pinckney honestly my LLM put this PR up without me explicitly asking it to... It was supposed to go to my fork https://github.com/wcygan/skill-temporal-developer first so that I can review it My idea was to start from the basics and keep the Rust references very lean to begin with (especially since this SDK is still in preview). For example it could start as a bare SKILL.md and reference high-level content such as https://docs.temporal.io/develop/rust and https://crates.io/crates/temporalio-sdk to help point the LLM at the right place, maybe keep an index of the relevant files here. Again, sorry that this draft was posted. The diff is huge... Let me try to reconcile! |
It's slightly better now, less AI slop, but now very minimal. I think it's a decent starting point. We could always add the reference files afterward. WDYT? |
|
Despite not doing it for the other languages, I don't mind this iterative rust.md file only approach, especially since Rust is still in preview. I put on a few simple suggestions, mostly around tagging it will public preview. I'll take another look later today to sanity check code samples, but generally looking good. |
|
@wcygan PR is looking pretty good. If you apply the changes I and @chris-olszewski suggested, I think we're good to merge! Thanks again btw! |
|
Thanks again for the reviews @donald-pinckney @chris-olszewski. This version should be nearly there. The code samples are just inlined from https://docs.temporal.io/develop/rust/quickstart, and the skill has warnings about being in preview now, let me know if you want any other changes! |
Addresses review comment on SKILL.md:62 (donald-pinckney).
Addresses review comment on README.md:43 (donald-pinckney).
Uses the reviewer's exact wording. Addresses review comment on references/rust/rust.md:1 (donald-pinckney).
Drops the pinned-version caveat now that there are no crate versions in the file. Addresses review comment on references/rust/rust.md:22 (chris-olszewski).
The Rust SDK always applies a to_close Activity timeout, so the pitfall does not apply. Addresses review comment on references/rust/rust.md:171 (chris-olszewski).
The examples are not at the repo top, so link the explicit path. Addresses review comment on references/rust/rust.md:177 (chris-olszewski).
wcygan
force-pushed
the
codex/init-rust-references
branch
from
b28a6cd to
57403ee
Compare
|
LGTM! Thanks @wcygan! |
|
swag, good work team. now let's keep building out the Rust SDK towards GA ;) |
4 participants
Summary
Add Rust SDK coverage to the Temporal developer skill so agents can route Rust Temporal work to focused reference material. The new references are grounded in the current official Rust developer guide and the Public Preview temporalio-sdk crate.
Changes
references/rust/rust.mdSKILL.mdrouting and the top-level overview.