Implement planned topic: 0016-spring-configuration#240
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0016-spring-configuration#240skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report — spring-configuration (Java Spring Boot integration)
Branch:
draft/0016-spring-configuration(changes uncommitted; validated against the working tree vs.main)Files in scope:
references/java/integrations/spring-boot.md(substantive rewrite)references/integrations.md(single catalog row updated)Docs source of truth:
../documentation/docs/develop/java/integrations/spring-boot.mdx(243 lines), with one cross-reference intospring-ai.mdx:68.Go / no-go
Overall verdict per template rubric: RE-RUN AUTHORING.
The two threshold misses (Checks 1 and 4) trace to a single four-word over-extension on one bullet at
spring-boot.md:209. Practically this is a one-line spot fix that would clear both thresholds. If the project applies a targeted re-author against just the auto-discovery bullet (plus the MINOR cleanup items below), all checks pass cleanly. Either route is defensible — the strict template rubric calls for RE-RUN AUTHORING; the substantive picture is closer to MINOR FIXES.Check 1 findings
Total citation comments scanned: 31.
Finding 1.1 —
spring-boot.md:209overstates the docsspring-boot.mdx:149says only "Workers if a Task Queue is referenced by the annotations but not explicitly configured. Default configuration will be used." The docs do not say Worker name is also a trigger. Either (a) drop "or Worker name" from the bullet, or (b) cite a different docs line that supports it. This is the single Check 1 failure and it also surfaces in Check 4.All other 30 citations resolve cleanly. Non-citation hyperlinks at
spring-boot.md:289(Plugin guide) andspring-boot.md:343(testing-suite) are both fullhttps://docs.temporal.io/...URLs — no root-relative findings.Check 2 findings
Result: no fabricated tokens.
Notes (informational, not findings):
spring-boot.md:25— "The starter transitively includestemporal-sdkand the autoconfigure module." Neithertemporal-sdk(in this transitive-dep context) nor "autoconfigure module" is stated inspring-boot.mdx. This is a reasonable inference about how the Maven starter is packaged, not a fabrication, but it is unsourced. Acceptable as background prose.spring-boot.md:275, 279—org.springframework.core.annotation.OrderFQCN expands whatspring-boot.mdx:172calls just@Order. Standard Spring API; not a fabrication risk.spring-boot.md:355—mainDataConverter/ "MultipleDataConverterbeans cause ambiguity" is self-flagged with<!-- VERIFY: not stated in spring-boot.mdx... -->. The VERIFY tag is accurate; per Check 2 rules this is excluded from findings here but Check 6 flags it as speculative-common-mistake content (see below).Check 3 findings
Result: zero hits.
--profile, noTEMPORAL_TLS_CLIENT_*env vars, notcld service-account, no--output text/jsonl, no port-7233 cloud endpoint, nosaas-api.tmprl.cloud:7233.@WorkflowImpl(taskQueues = ...)/@ActivityImpl(taskQueues = ...)(all four occurrences correctly useworkers = "..."); no camelCaseworkersAutoDiscovery.packages(all uses are kebab-caseworkers-auto-discovery); nospring.temporal.start-workers; no open Maven/Gradle version ranges ([1.0,),1.+) — bothpom.xmlandbuild.gradleexamples pin1.31.0.The branch successfully removes the previous-pass regressions (
taskQueues = ..., camelCaseworkersAutoDiscovery,start-workers, open versions).Check 4 findings
Sampled citations (10 of 31, seeded spread + mandatory version claim):
indices 1, 2, 7, 13, 18, 22, 26, 27, 31, 38.
io.temporal:temporal-spring-boot-starteris the starter artifactActivityImplmust be a Spring bean;@Componentdocumentednamedefaults to Task Queue when omittedTemporalOptionsCustomizer<OptionsBuilderType>runs after properties appliedTestWorkflowEnvironmentMatch rate: 9 / 10 = 90%. Below the 95% threshold by one finding, which is the same one as Check 1.1. Single-instance over-extension, not a systemic interpretation drift.
The version/prerequisite claim (#2) passes: Spring Boot 2.x / 3.x / 4.x is supported by
spring-boot.mdx:34verbatim. No SDK-version-floor claim in the authored file beyond the pinned1.31.0Maven coordinate (which docs:43,50 confirm).Check 5 findings (integration topic)
references/java/integrations/spring-boot.mdreferences/integrations.mdSKILL.mdedit (git diff main -- SKILL.mdempty)references/java/java.mdFinding 5.3 — catalog row description is too long for a TL;DR column
references/integrations.md:16now reads:Six distinct concept areas with a nested parenthetical listing YAML keys. Peer rows (LangSmith, LangGraph, etc.) keep to a single clause. Recommend a one-clause rewrite, e.g.:
This is a layout-only finding — MINOR fix.
Check 6 findings (tone and scope)
MAJOR (workaround disclosure): none. No "don't do X, but if you really need to…" bullets. The Gotchas section ends each negative bullet at the supported alternative or at a hard constraint.
MINOR findings
spring-boot.md:355. ThemainDataConverter"MultipleDataConverterbeans cause ambiguity" bullet is self-flagged with<!-- VERIFY: not stated in spring-boot.mdx... -->. The VERIFY tag is the author's own admission that this is convention-based, not documented. Remove the bullet, or replace with a documented gotcha. Shipping a VERIFY tag in a released reference file is a finding by itself.spring-boot.md:347("Workflow impls must not have@Component"). The middle two sentences explain why; the final sentence restates the constraint. The agent only needs the first sentence (or first + last). Trim to one statement.spring-boot.md:351("@WorkflowImpl/@ActivityImplwithoutworkers-auto-discovery.packagesis silently ignored"). The trailing "Verify in the Temporal UI…" sentence is human-debugger advice, not codegen guidance.spring-boot.md:213("ActivityImplandNexusServiceImplonly work when the implementation is a Spring bean") restates whatspring-boot.md:140already authoritatively stated. Drop the duplicate.spring-boot.md:289("These three interceptor interfaces are the only ordering hook the integration documents — there is no Temporal-specific ordering API"). The second clause is meta-narrative; the agent doesn't need to know what's absent, only what to use. Trim to: "These three interceptor interfaces are the only ordering hook the integration documents."Acceptable patterns observed (NOT findings):
WorkflowServiceStubs→WorkflowClient→WorkerFactorysetup" — frames the integration's value succinctly; borderline but acceptable as Overview prose.ApplicationContext, not an overloaded SDK handle).plugins-guideis not a duplicate — there is no localreferences/core/plugins*.md.Check 7
Skipped — Spring Boot integration is Java-only, not a cross-SDK feature.
Statistics
Recommended fixes (substantive picture)
If the project prefers to spot-fix rather than re-run authoring, the following edits clear every open finding:
references/java/integrations/spring-boot.md:209— deleteor Worker name, leavingif a Task Queue is referenced by one of the annotations but not explicitly configured…. Clears Check 1.1 and Check 4 (raises Check 1 to 100%, Check 4 to 100%).references/java/integrations/spring-boot.md:355— remove themainDataConverterbullet (including the VERIFY tag) or replace with a documented gotcha. Clears Check 6 finding 1.references/integrations.md:16— shrink the Spring Boot catalog description to a single TL;DR clause. Clears Check 5.3.spring-boot.md:213, 289, 347, 351— trim multi-sentence bullets per Check 6 findings 2-5.End of report.