You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No objection to preferring type="authorization" for EIP-3009 tokens when
there are no splits. The line you draw (authorization for simple single
transfers, Permit2 for splits and server-paid fees) is the right one, since
EIP-3009 transferWithAuthorization cannot express atomic splits.
One coordination note: #313 also edits this section of draft-evm-charge-00.md. It removes the redundant externalId from the
Permit2 PaymentWitness, because every request field (including externalId
when present) is already bound through challengeHash. That change is
orthogonal to the preference change here (witness cleanup vs recommended
type), and I confirmed #313 rebases cleanly on top of this PR with no
conflicts. Happy to sequence #313 after this one merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer
authorizationfor tokens known to support EIP-3009 when no splits are requested.Permit2 remains the preferred option otherwise.
Refs #264