fix(fee-payer): reject admin requests when ADMIN_SECRET is unset - #1098
Open
gordera wants to merge 1 commit into
Open
fix(fee-payer): reject admin requests when ADMIN_SECRET is unset#1098gordera wants to merge 1 commit into
gordera wants to merge 1 commit into
Conversation
When the KV binding is present but ADMIN_SECRET is not configured, the bearer comparison degraded to 'Bearer undefined', authenticating anyone who sent it. Return 503 before comparing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden admin guard against missing ADMIN_SECRET
ADMIN_SECRETis optional (env.d.ts:readonly ADMIN_SECRET?: string).auth !== \Bearer ${env.ADMIN_SECRET}``."Bearer undefined".Authorization: Bearer undefinedis then authenticated.Fix:
503up front whenenv.ADMIN_SECRETis falsy — before any header comparison.Notes: