Mark gradient_test as flaky#1067
Open
mhucka wants to merge 2 commits into
Open
Conversation
The test in `gradient_test.py` fails in CI about 50% of the time at random.
mhucka
added
area/health
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request marks the gradient_test in the tensorflow_quantum/python/differentiators/BUILD file as flaky. Feedback indicates that combining a flaky designation with an 'eternal' timeout is problematic for CI efficiency and reliability, as it may block the merge queue and increase costs; it is recommended to address the root cause of the test's non-determinism or disable it until stabilized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test in
gradient_test.pyfails randomly in CI about 50% of the time. This then wastes maintainer time looking at the logs, re-running the checks on PRs, and babysitting things. It's especially annoying when it happens during merge queue events.This PR simply marks that test as flaky using Bazel's feature for that purpose. That should in turn cause Bazel to retry the failed test.