Skip to content

Fix CPU resizeBilinear gradient shape for non-square inputs #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChengCK18 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CPU resizeBilinear gradient shape for non-square inputs #8758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tfjs-backend-cpu/src/kernels/ResizeBilinearGrad.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export function resizeBilinearGrad(args: {
}

return backend.makeTensorInfo(
[batch, xWidth, xHeight, depth], 'float32', output);
[batch, xHeight, xWidth, depth], 'float32', output);
}

export const resizeBilinearGradConfig: KernelConfig = {
Expand Down
18 changes: 18 additions & 0 deletions tfjs-core/src/ops/image/resize_bilinear_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,4 +976,22 @@ describeWithFlags('resizeBilinear gradients', ALL_ENVS, () => {
[1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0, 11.0, 12.0];
expectArraysClose(await output.data(), expected);
});

it('greyscale: upscale, non-square input, align corners', async () => {
const input = tf.tensor3d([[[1], [2], [3]], [[4], [5], [6]]]);
const dy = tf.tensor3d([
[[1], [2], [3], [4], [5]], [[6], [7], [8], [9], [10]],
[[11], [12], [13], [14], [15]], [[16], [17], [18], [19], [20]]
]);

const size: [number, number] = [4, 5];
const alignCorners = true;
const g = tf.grad(
(i: tf.Tensor3D) => tf.image.resizeBilinear(i, size, alignCorners));

const output = g(input, dy);
expect(output.shape).toEqual([2, 3, 1]);
expectArraysClose(
await output.data(), [14, 76 / 3, 24, 39, 176 / 3, 49]);
});
});
Loading