Open
Conversation
ddavis-2015
reviewed
Feb 9, 2026
Member
ddavis-2015
left a comment
ddavis-2015
left a comment
There was a problem hiding this comment.
@veblush The CMSIS_NN optimized kernel also needs to be updated.
Comment on lines
+353
to
+364
| // We can only flatten the dimensions if the physical layout in memory | ||
| // allows us to treat [Batch, Row, Col] as [Batch * Row, Col]. | ||
| // This requires the 'Row' dimension to be contiguous with the 'Batch' | ||
| // dimension. | ||
| // | ||
| // If adj_x is true, the logical operation is on transposed matrices. | ||
| // The physical layout is [Batch, Row, Col] but logically we access [Batch, | ||
| // Col, Row]. Flattening Batch and Row dimensions (physically) results in | ||
| // [Batch*Row, Col]. This does not match the logical expectation of [Batch, | ||
| // Col, Row] because the columns of the second batch are not contiguous with | ||
| // the columns of the first batch in the logical transposed view. Therefore, | ||
| // we disable this optimization when adj_x is true. |
Member
There was a problem hiding this comment.
Hmmm. This means the LiteRT code also needs to be corrected.
veblush
had a problem deploying
to
integration-test
GitHub Actions
Error
Added BatchMatMulOpTestFloat32Test_BatchSizeTwo_Broadcast_RHSAdjoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batmul
ReshapeToFlattenBatchDimsIfPossiblefor better maintainability.BUG=#3412