feat(orchestrator): impl LearningStore on SharedLearningStore#848
Merged
AlexMikhalev merged 1 commit intomainfrom Apr 24, 2026
Merged
feat(orchestrator): impl LearningStore on SharedLearningStore#848AlexMikhalev merged 1 commit intomainfrom
AlexMikhalev merged 1 commit intomainfrom
Conversation
5 tasks
Adds sync LearningStore trait impl on orchestrator's SharedLearningStore with sync-to-async bridge via tokio::task::block_in_place. Includes type conversion functions and corrected InMemoryLearningStore test assertions. Refs #813
AlexMikhalev
force-pushed
the
task/813-learning-store-impl-v2
branch
from
a06e1a1 to
d259062
Compare
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
Adds sync LearningStore trait impl on orchestrator's SharedLearningStore with sync-to-async bridge via tokio::task::block_in_place. Includes type conversion functions and corrected InMemoryLearningStore test assertions. Refs #813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terraphim_types::shared_learning::LearningStore(sync trait) on orchestrator'sSharedLearningStoretokio::task::block_in_place(types crate has no async runtime)to_shared_learning(),convert_trust()InMemoryLearningStoretest assertions (archive_stale and auto_promote)features = ["kg-integration"]to orchestrator'sterraphim_typesdependencyTest plan
cargo test -p terraphim_orchestrator— 518 tests pass includingtest_learning_store_trait_implcargo clippy -p terraphim_orchestrator -- -D warnings— cleancargo test -p terraphim_types --features kg-integration— 76 tests passRefs #813