fix(security): enforce trust boundary before UMLS deserialize_unchecked Refs #1733#876
Merged
Merged
Conversation
…ed Refs #1733 Convert advisory permission warning to hard error. An attacker who can write the artifact file can forge both bytes and checksums together, making the checksum gate useless for integrity. Changes: - medical_artifact.rs: world-writable and group-writable artifacts now bail before any data is read on Unix. - sharded_extractor.rs: update SAFETY comment to list both enforced gates (permission check + checksum verification). - Tests: replace advisory-success test with rejection tests for world-writable and group-writable, add secure-permissions test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the advisory permission warning for UMLS artifacts to a hard error. An attacker who can write the artifact file can forge both bytes and checksums, rendering the SHA-256 gate useless without permission enforcement.
Changes
anyhow::bail!before any data is read (Unix only).test_world_writable_artifact_loads_ok(which expected permissive behavior) with three new tests:test_world_writable_artifact_rejectedtest_group_writable_artifact_rejectedtest_secure_permissions_artifact_loads_okVerification
cargo test -p terraphim_automata --lib: 76 passedcargo fmt,cargo clippy,cargo build,cargo test: cleanRefs terraphim/terraphim-ai#1733 (Gitea)