Skip to content

fix(envision): add -fPIE - #13841

Open
madonuko wants to merge 1 commit into
frawhidefrom
mado/fix/envision
Open

fix(envision): add -fPIE#13841
madonuko wants to merge 1 commit into
frawhidefrom
mado/fix/envision

Conversation

@madonuko

@madonuko madonuko commented Jul 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@hamachitan hamachitan Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣 The Packager: name <mail@example.com> preamble is missing in anda/apps/envision/envision.spec. This is required in our policies.

@madonuko
madonuko enabled auto-merge (squash) July 9, 2026 08:31
@GildedRoach

Copy link
Copy Markdown
Member

Build error is weird but this is already set via the RH hardening.
image

@GildedRoach

GildedRoach commented Jul 11, 2026

Copy link
Copy Markdown
Member

Just noticed this issue, but the correct macro is _pkg_extra_cflags etc.

@julian45

julian45 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Build error is weird but this is already set via the RH hardening. image

Aha, the fPIE bit gave me a good hint :)
I just ran into a similar issue with Continuwuity earlier this week. I checked the action output, and lo and behold: even though upstream doesn't explicitly call for it in their Cargo.toml, they have a transitive dependency on aws-lc-rs and aws-lc-sys somewhere that must have been bumped to 0.42.0 recently. This is a known issue super-upstream, and the only known good workaround is to explicitly pin these prior versions in the software being packaged: aws-lc-rs 1.17.0 and aws-lc-sys 0.41.0.

Ideally, the upstream software you're packaging should implement this themselves, but you might need to monkey-patch it here if they can't/won't.

@julian45

Copy link
Copy Markdown
Contributor

Supposedly, the aforementioned issue is fixed in aws-lc-rs 1.17.3/aws-lc-sys 0.43.0.

@madonuko

Copy link
Copy Markdown
Member Author

by the way _pkg_extra_flags should not be used, it's not supported on older releasevers

@GildedRoach

Copy link
Copy Markdown
Member

by the way _pkg_extra_flags should not be used, it's not supported on older releasevers

Source? Because everything in the Fedora information still mentions it and it's still in redhat-rpm-config on Rawhide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants