fix(chartgen): pull images with policy Always in generated charts - #32
Merged
Merged
Conversation
The sandbox registry serves mutable tags — every 'sandboxctl build' re-pushes the same tag — but generated values defaulted image.pullPolicy to IfNotPresent, and Kubernetes only defaults to Always for the literal :latest tag. Result: after a rebuild, rollout restarts kept running the node's cached image instead of pulling the fresh push, silently. pullPolicy: Always is now pinned in every generated values surface: the chart's values.yaml default (with the why), values-sandbox.yaml, the umbrella's nested per-app blocks, and values-staging.yaml. The deployment template falls back to Always when values omit the key. Because values-sandbox/umbrella/values-staging are refresh-tracked files, existing repos heal with one re-scaffold: the sandbox flavour override beats a stale IfNotPresent left in an old chart's values.yaml (verified by rendering the umbrella over an old chart — all deployments come out Always). Regression test pins all surfaces.
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated charts defaulted
image.pullPolicy: IfNotPresentwhile the sandbox registry serves mutable tags (everysandboxctl buildre-pushes the same tag). Kubernetes only defaults toAlwaysfor the literal:latest, so after a rebuild the rollout restart deploy performs kept running the node's cached image — stale code, no error, nothing to see.Fix
pullPolicy: Alwayspinned in every generated values surface:values.yamldefault (with a comment explaining why)values-sandbox.yaml(per-app)values-sandbox.yamlnested per-app blocksvalues-staging.yamlAlwayswhen values omit the key entirelyExisting repos heal with one re-scaffold: the sandbox/staging/umbrella values are refresh-tracked (v3.1.7), and a flavour-level
Alwaysoverrides a staleIfNotPresentsitting in an old chart'svalues.yaml— no need to touch the user's base values.Verification
values.yaml: IfNotPresent, no key in values-sandbox) → re-scaffold → umbrellahelm templaterendersimagePullPolicy: Alwayson all 3 deploymentsvalues-staging.yamlrefreshed withAlwaysbash -n,gofmt,go vet, fullgo test(8 pkgs) green