[WIP] Add 3-2-1 countdown before recording starts#1
Merged
theabhipareek merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
Copilot stopped work on behalf of
theabhipareek due to an error
April 16, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Original prompt
Add 3-2-1 Countdown Before Recording Starts
Problem
When users press the Record button, capture starts immediately with no pre-roll countdown. This can lead to accidental recording of setup actions.
Solution
Implement a visible 3-2-1 countdown that displays after pressing Record. The actual recording should only begin when the countdown reaches zero. Users should be able to cancel the countdown by pressing Record again.
Implementation Details
1. Update useScreenRecorder Hook (
src/hooks/useScreenRecorder.ts)countdownSecondsandisCountingDownstartCountdown()function that:startRecording()after countdown completestoggleRecording()to callstartCountdown()instead ofstartRecording()directly2. Update LaunchWindow Component (
src/components/launch/LaunchWindow.tsx)isCountingDownis true3. Features
Testing Checklist
The following is the prior conversation context from the user's chat exploration (may be truncated):
User: @siddharthvaddem/openscreensiddharthvaddem/pull/427
review this PR
Assistant: I'll review this PR for you. Let me fetch the details about the pull request.
Assistant: ## PR Review: Audio Hooks & Music Timeline Support
Status: Open | Author: imAaryash | Created: 3 days ago | 8 commits | 70 files changed (+3,022, -324)
Overview
This PR adds comprehensive audio functionality to the OpenScreen video editor:
Key Changes
openAudioFilePicker()handler with support for.mp3,.wav,.m4a,.aac,.ogg,.flac,.webm🔴 Critical Issues
1. Missing
webcamSizePresetin Project SnapshotFile:
src/components/video-editor/VideoEditor.tsx(lines 346-403)Severity: 🟠 Major
The
currentProjectSnapshotmemo excludeswebcamSizePreset, breaking unsaved-change detection for webcam size edits.Fix: Add
webcamSizePresetto thecreateProjectSnapshotobject alongside other project fields.2. Multiple Hook Events Dropped in Single Frame
File:
src/lib/exporter/audioEncoder.ts(lines 481-490)Severity: 🟠 Major
The hook event trigger uses
events.some(...)which only fires once per frame, dropping additional events that land simultaneously.Current:
Should be: Iterate all events and call
playHookSound()for each crossing.3. Import Organization Linting Failure
File:
src/components/video-editor/SettingsPanel.tsx(lines 1-18)Severity: 🟡 Minor
Biome linting flagged import ordering. Run:
npx biome check --write src/components/video-editor/SettingsPanel.tsx🟡 Important Concerns
4. Hardcoded English UI Strings (i18n Gaps)
Multiple hardcoded strings bypass localization:
electron/ipc/handlers.ts(line 768): Dialog title "Select audio" and filter namesThis pull request was created from Copilot chat.