Add Pulp plugins section#57
Merged
Merged
Conversation
ogajduse
force-pushed
the
add-pulp-plugins-section
branch
from
67d6d00 to
ee87dee
Compare
Member
Author
|
Great review comments, thank you, @ekohl. It's ready for re-review. |
ekohl
reviewed
Apr 21, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Some further suggestions to keep it short, but overall 👍
ekohl
reviewed
Apr 21, 2026
ogajduse
force-pushed
the
add-pulp-plugins-section
branch
from
ee87dee to
b498066
Compare
Add dedicated section for Pulp plugins that integrate with Foreman
ecosystem. These are Python-based plugins packaged in pulpcore-packaging,
distinct from libraries and Smart Proxy modules.
Changes based on review feedback:
- Auto-derive RPM package name from plugin name (python-pulp-{name})
- Auto-generate default tests (ci.yml from pulp plugin_template)
- Remove unused rpm_directory and deb_directory fields
- Simplify rpm_url property to use pulpcore-packaging directly
- Always render Pulp Plugins section (no conditional checks)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ogajduse
force-pushed
the
add-pulp-plugins-section
branch
from
b498066 to
50a30e0
Compare
ogajduse
commented
Apr 24, 2026
The pulp_smart_proxy plugin is now managed by the foremanctl team, as confirmed in the review discussion.
ehelms
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
pulp_pluginssection to the Foreman plugin overview website for Pulp plugins that integrate with the Foreman ecosystem.Changes
PulpPlugindataclass with:pulp_{short_name}→pulp_smart_proxypython-pulp-{name}(with dashes)ci.ymlinstaller: falseby defaultpulp_pluginssection with first entry:smart_proxyFirst Plugin
python-pulp-smart-proxyin pulpcore-packagingRelated: Issue #58 proposes extending auto-generation to other plugin types
🤖 Generated with Claude Code