Fixes #39321 - Remove SSH providers from BMC#10984
Merged
Merged
Conversation
arvind4501
force-pushed
the
remove-bmc-ssh
branch
from
eb15913 to
635ace9
Compare
arvind4501
changed the title
stejskalleos
approved these changes
May 14, 2026
Contributor
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
Changes LGTM, I have not found any other places where the SSH provider is used.
Once the CI is green, we can merge
@arvind4501 once the Smart Proxy PR is ready, please link it here.
Contributor
|
The Katello failures are not related to the changes in this PR, let's get this in! |
evgeni
reviewed
May 15, 2026
| ipmi = bmc_nic | ||
| return false if ipmi.nil? | ||
| (ipmi.credentials_present? && %w(IPMI Redfish).include?(ipmi.provider)) || ipmi.provider == 'SSH' | ||
| (ipmi.credentials_present? && %w(IPMI Redfish).include?(ipmi.provider)) |
Member
There was a problem hiding this comment.
I know this is already merged, but given IPMI and Redfish are the only providers left, this could be:
Suggested change
| (ipmi.credentials_present? && %w(IPMI Redfish).include?(ipmi.provider)) | |
| ipmi.credentials_present? |
the "credentials present and IPMI/Redfish" was only needed to shortcut to "or SSH"
Member
Author
Member
There was a problem hiding this comment.
IMHO you can just do Refs #39321 as that's not in a released version of Foreman yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RFC , there is proposal to remove SSH and Shell as BMC providers, “SSH” is exposed in the Foreman UI (even if not functional in the default config).