Move default certificate path to /var/lib/foremanctl/certs#476
Open
ehelms wants to merge 1 commit intotheforeman:masterfrom
Open
Move default certificate path to /var/lib/foremanctl/certs#476ehelms wants to merge 1 commit intotheforeman:masterfrom
ehelms wants to merge 1 commit intotheforeman:masterfrom
Conversation
Certificates are application-managed state, not user-editable config. /var/lib/foremanctl/certs follows conventions for persistent data owned by the application rather than /root/certificates which implied user ownership. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Certificates that are generated and managed by
foremanctlshould live in an appropriate location on the file system that indicates to the admin. Inforeman-installer, these certificates lived in/root/ssl-buildwhich was always seen as a non-standard location. These certificates should not be touched by the user, and thus/varis the best location to store and indicate this to the user.What are the changes introduced in this pull request?
/root/certificatesto/var/lib/foremanctl/certs.How to test this pull request
Steps to reproduce:
./foremanctl deploy/var/lib/foremanctl/certsChecklist