Skip to content

Update smart-proxy name configuration for development#477

Open
pondrejk wants to merge 1 commit intotheforeman:masterfrom
pondrejk:patch-1
Open

Update smart-proxy name configuration for development#477
pondrejk wants to merge 1 commit intotheforeman:masterfrom
pondrejk:patch-1

Conversation

@pondrejk
Copy link
Copy Markdown
Contributor

Why are you introducing these changes? (Problem description, related links)

This change makes "internal" capsule naming consistent with downstream which in turn makes robottelo easier to use against dev environment

What are the changes introduced in this pull request?

  • proxy name from hostname-dev to hostname

@ehelms
Copy link
Copy Markdown
Member

ehelms commented Apr 28, 2026

This change makes "internal" capsule naming consistent with downstream which in turn makes robottelo easier to use against dev environment

You got me curious. How is this used inside robottelo? What tests / workflows?

@pondrejk
Copy link
Copy Markdown
Contributor Author

You got me curious. How is this used inside robottelo? What tests / workflows?

I only started exploring this, but the idea is to use the setup fixtures from robottelo to create reproducers on devel setup that would be long/annoying to prepare by hand (things like external auth, living hosts registered through external capsules, provisioned hosts, things like that)

@ehelms
Copy link
Copy Markdown
Member

ehelms commented Apr 29, 2026

I only started exploring this, but the idea is to use the setup fixtures from robottelo to create reproducers on devel setup that would be long/annoying to prepare by hand (things like external auth, living hosts registered through external capsules, provisioned hosts, things like that)

Fair. I am curious then, how is the smart-proxy / foreman-proxy / capsule referenced inside robottelo? How is it being used in this fixture creation?

@pondrejk
Copy link
Copy Markdown
Contributor Author

pondrejk commented May 4, 2026

Fair. I am curious then, how is the smart-proxy / foreman-proxy / capsule referenced inside robottelo? How is it being used in this fixture creation?

https://github.com/SatelliteQE/robottelo/blob/6f474e655f5648feaf3a7c8b2befa8c49b6e9c8d/pytest_fixtures/component/smartproxy.py#L7
Basically the expectation is for default proxy to be the same hostname as Satellite, current workaround for me is to add -dev at line 10

@ehelms
Copy link
Copy Markdown
Member

ehelms commented May 4, 2026

I think this identifies that, just as we are breaking our assumptions in our deployment, that the testing needs to make less assumptions and lean into the features. In this case, instead of assuming a default proxy and that it will have certain capabilities, we should be leaning into finding a proxy with the features that is needed for the test. We might can get away with ensuring the url has the same hostname to find the "local" foreman-proxy. Relying on the name however, just won't cut it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants