Filter out grid points with negligible weights in horton3 adapter#36
Open
Ao-chuba wants to merge 4 commits intotheochem:mainfrom
Open
Filter out grid points with negligible weights in horton3 adapter#36Ao-chuba wants to merge 4 commits intotheochem:mainfrom
Ao-chuba wants to merge 4 commits intotheochem:mainfrom
Conversation
Member
There was a problem hiding this comment.
Pull request overview
This PR implements a performance optimization by filtering out grid points with negligible weights (< 1e-15) in the horton3 adapter during grid setup, addressing a TODO comment that was present in the code.
Changes:
- Added import of
Gridfromgrid.basegridto enable creation of filtered grid objects - Implemented filtering logic to remove grid points with weights below 1e-15 when
store_atgrids=False - Removed the TODO comment about removing zero-weight grid points
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@PaulWAyers |
99f8d95 to
a85f4d7
Compare
Author
e58c6a5 to
5be88d8
Compare
for more information, see https://pre-commit.ci
Author
|
@tovrstra @FarnazH
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
horton3 adapterto filter out grid points with negligible weights (< 1e-15) duringgrid setup, ensuring cleaner data for density partitioning.Changes
src/denspart/adapters/horton3.pyMotivation
Grid points with essentially zero weight do not contribute to the density partitioning and can cause numerical noise or inefficiency. Filtering them out ensures the grid contains only significant points.
Verification
density-water.npz) and that negligible weights are effectively ignored (confirmed viacheck_weights.pyanalysis before cleanup).closes #35