Skip to content

fix: Restore right-click delete after merge with undo/delete controls #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianjon3s merged 1 commit into from
Oct 1, 2026
Merged

fix: Restore right-click delete after merge with undo/delete controls #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/components/my-map/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,12 @@ export class MyMap extends LitElement {

// Track whether a shape is part-way through being drawn
let isSketching = false;
draw.on("drawstart", () => (isSketching = true));
draw.on(["drawend", "drawabort"], () => (isSketching = false));
draw.on("drawstart", () => {
isSketching = true;
});
draw.on(["drawend", "drawabort"], () => {
isSketching = false;
});

const handleDelete = () => {
if (isSketching) draw.abortDrawing();
Expand Down Expand Up @@ -643,11 +647,6 @@ export class MyMap extends LitElement {
// Snap must be added after draw and modify
map.addInteraction(snap);

// Track whether a polygon is part-way through being drawn
let isDrawing = false;
draw.on("drawstart", () => (isDrawing = true));
draw.on(["drawend", "drawabort"], () => (isDrawing = false));

// Delete the point under the draw pointer, returning whether one was deleted
const deletePointAtPixel = (pixel: number[]): boolean => {
// Only delete when close enough to the point's centre for Modify to show the draw pointer
Expand Down Expand Up @@ -686,7 +685,7 @@ export class MyMap extends LitElement {

// Right-click to undo the last vertex while drawing, or delete the point/vertex under the draw pointer
map.getViewport().addEventListener("contextmenu", (event) => {
if (isDrawing) {
if (isSketching) {
event.preventDefault();
draw.removeLastPoint();
return;
Expand Down
Loading