Fix client credentials overriding getSubjectIdentifier
#208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `league/server-bundle` version `0.8`, when the client_credentials grant is used, the `sub` claim of the JWT is an empty string, but in version `0.9` is filled with the client ID. We override the `getSubjectIdentifier` of the AccessToken entity to return an empty string again when the client_credentials grant is used.
ajgarlag
force-pushed
the
fix-client-credentials-1
branch
from
f1a1bda to
017ad9d
Compare
ajgarlag
changed the title
getSubjectIdentifier
Member
|
Closing in favor of #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
league/server-bundleversion0.8, when the client_credentialsgrant is used, the
subclaim of the JWT is an empty string, but inversion
0.9is filled with the client ID.We override the
getSubjectIdentifierof the AccessToken entity toreturn an empty string again when the client_credentials grant is used.
Fix #207