Skip to content

Conversation

@ajgarlag
Copy link
Contributor

@ajgarlag ajgarlag commented Nov 3, 2025

It was using an 'IN' clause in fields stored as a space separated
string of values.

@ajgarlag ajgarlag force-pushed the fix-client-filtering branch from 6b7c593 to cdf94ae Compare November 3, 2025 09:16
 It was using an 'IN' clause in fields stored as a space separated
 string of values.
@ajgarlag ajgarlag force-pushed the fix-client-filtering branch from cdf94ae to 2ce4f54 Compare November 5, 2025 07:17
@ajgarlag
Copy link
Contributor Author

ajgarlag commented Nov 5, 2025

@chalasr Could you review this PR??

The bug was always there. The conversion of ClientFilter to Doctrine criteria was wrong, but it was spotted indirectly after doctrine/orm#12190

@chalasr
Copy link
Member

chalasr commented Nov 6, 2025

Good catch, thanks @ajgarlag.

@chalasr chalasr merged commit 92ae92d into thephpleague:master Nov 6, 2025
24 checks passed
@ajgarlag ajgarlag deleted the fix-client-filtering branch November 6, 2025 21:40
chalasr added a commit that referenced this pull request Nov 6, 2025
This PR was merged into the 1.x-dev branch.

Discussion
----------

Update unit tests configuration

* remove Symfony 7.1
* remove Symfony 7.2
* add Symfony 7.3
* add Symfony 7.4

This PR includes #257

Commits
-------

ba038e9 Update unit tests configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants