-
Notifications
You must be signed in to change notification settings - Fork 350
ipc4: base_fw: Request empty Astate table #10523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improve IPC4 compatibility in respect to the Astate table that is received by FW as a part of set_large_config IPC. The table contains maximal KCPS thresholds, one for each supported clock source. Currently SOF FW performs autonomous management of clock sources and does not take such a configuration into account. Despite this, FW reports through get_large_config its support for 3 elements of Astate table. This change sets the supported Astate table size to 0. Also, as a corner case, a trivial handler is added for handling the empty table. Signed-off-by: Wojciech Jablonski <[email protected]>
softwarecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@lgirdwood @wjablon1 this was merged despite introducing a CI regression https://github.com/thesofproject/sof/actions/runs/21713822303/job/62624107831 |
|
|
Looks like issue with static assert. From reddit:
“ you can't declare a variable on the line immediately after a case x: unless the whole case block is scoped with brackets”
I will fix this.
Thanks,
Wojciech
From: Kai Vehmanen ***@***.***>
Sent: Friday, February 6, 2026 9:41 AM
To: thesofproject/sof ***@***.***>
Cc: Jablonski, Wojciech ***@***.***>; Mention ***@***.***>
Subject: Re: [thesofproject/sof] ipc4: base_fw: Request empty Astate table (PR #10523)
[Image removed by sender.]kv2019i left a comment (thesofproject/sof#10523)<#10523 (comment)>
@lgirdwood<https://github.com/lgirdwood> @wjablon1<https://github.com/wjablon1> this was merged despite introducing a CI regression https://github.com/thesofproject/sof/actions/runs/21713822303/job/62624107831
#10527<#10527>
—
Reply to this email directly, view it on GitHub<#10523 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWR3ROLGTE546CNQ35ZJECL4KRHRJAVCNFSM6AAAAACUDBMAD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNJYHAZDSOJSGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
|
Improve IPC4 compatibility in respect to the Astate table that is received by FW as a part of set_large_config IPC. The table contains maximal KCPS thresholds, one for each supported clock source. Currently SOF FW performs autonomous management of clock sources and does not take such a configuration into account. Despite this, FW reports through get_large_config its support for 3 elements of Astate table. This change sets the supported Astate table size to 0. Also, as a corner case, a trivial handler is added for handling the empty table.