Skip to content

dts: validate parameter size against remaining config blob #10879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgirdwood wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

dts: validate parameter size against remaining config blob #10879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/audio/codec/dts/dts.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,16 +328,29 @@ static int dts_codec_apply_config(struct processing_module *mod)

/* Allow for multiple module_params to be packed into the data pointed to by config
*/
param_header_size = sizeof(param->id) + sizeof(param->size);
for (i = 0; i < config_data_size; param_number++) {
/* Need at least a param header in the remaining bytes to read id/size */
if (config_data_size - i < param_header_size) {
comp_err(dev, "param header truncated");
return -EINVAL;
}

param = (struct module_param *)((char *)config->data + i);
param_header_size = sizeof(param->id) + sizeof(param->size);

/* If param->size is less than param_header_size, then this param is not valid */
if (param->size < param_header_size) {
comp_err(dev, "param is invalid");
return -EINVAL;
}

/* The whole param (header + data) must fit in the remaining config data */
if (param->size > config_data_size - i) {
comp_err(dev, "param size %u exceeds remaining %u",
param->size, config_data_size - i);
return -EINVAL;
}

/* Only process param->data if it has size greater than 0 */
if (param->size > param_header_size) {
/* Calculate size of param->data */
Expand Down
Loading