Skip to content

refactor: fix retry behaviour in tedge_flows.robot#4175

Open
jarhodes314 wants to merge 3 commits into
thin-edge:mainfrom
jarhodes314:fix/broken-flows-retries
Open

refactor: fix retry behaviour in tedge_flows.robot#4175
jarhodes314 wants to merge 3 commits into
thin-edge:mainfrom
jarhodes314:fix/broken-flows-retries

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

Proposed changes

Modify the tests in tedge_flows.robot so retries are handled correctly.

For example, this failure shows a Directory not empty error when we retried the test: https://github.com/thin-edge/thin-edge.io/actions/runs/25811734528/job/75832244151. This is due to the directory not being cleaned-up at the end of the test, so the retry tries to install the already-installed flow and fails at that point.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
…ntended

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 requested a review from a team as a code owner May 15, 2026 10:07
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request May 15, 2026 10:07 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
912 0 4 912 100 2h37m10.950313999s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant