Conversation
There was a problem hiding this comment.
Code Review
This is an automated benchmark data update — no source code changes. A few observations:
Overall: LGTM for an automated data PR.
Structural Change Worth Noting
lost the Median field from all entries in this update. All other JSON files retain it. This schema inconsistency could cause issues if anything consuming this JSON expects Median to be present on all benchmark results.
If the benchmark runner conditionally emits Median (e.g., only when enough samples are collected, or only for certain run configs), the automation workflow should either:
- Normalize the output schema before committing, or
- Document that
Medianis optional and ensure all consumers handle its absence gracefully.
Benchmark Results
Numbers look like routine variance from a nightly run. The +30% regression in Moq's CombinedWorkflow (310 → 403 μs) is notable but consistent with Moq's typical benchmarked behavior — TUnit.Mocks continues to show ~250x better performance in that category (1.64 μs vs 403 μs).
No Issues With the Automation Itself
The PR description is well-structured and the file set is consistent with the workflow intent. The docs/ scope is correctly bounded.
There was a problem hiding this comment.
Code Review
This is an automated benchmark data update — no source code changes.
Overall: LGTM for an automated data PR.
Structural Change Worth Noting
docs/static/benchmarks/mocks/Setup.json lost the Median field from all entries in this update. All other JSON files retain it. This schema inconsistency could cause issues if anything consuming this JSON expects Median to be present on all benchmark results.
If the benchmark runner conditionally emits Median, the automation workflow should either:
- Normalize the output schema before committing, or
- Document that
Medianis optional and ensure all consumers handle its absence gracefully.
Benchmark Results
Numbers look like routine variance from a nightly run. The +30% regression in Moq CombinedWorkflow (310 → 403 μs) is notable but consistent with expected behavior — TUnit.Mocks continues to show ~250x better performance in that category (1.64 μs vs 403 μs).
No Issues With the Automation
The PR description is well-structured and the file set is consistent with the workflow intent. The docs/ scope is correctly bounded.
Automated Mock Benchmark Update
This PR updates the mock benchmark documentation with the latest results from the Mock Benchmarks workflow.
Benchmarks Produced
Individual benchmark artifacts are available for download:
mock-benchmark-MockCreationmock-benchmark-Setupmock-benchmark-Invocationmock-benchmark-Verificationmock-benchmark-Callbackmock-benchmark-CombinedWorkflowmock-benchmark-summary(aggregated overview)Libraries Compared
Libraries are discovered dynamically from the benchmark output. See the generated
summary.jsonfor the full list.Changes
docs/static/benchmarks/mocks/latest.jsondocs/docs/benchmarks/mocks/docs/static/benchmarks/mocks/summary.jsonWorkflow Run
🤖 This PR was automatically created and will be merged automatically once CI checks pass.