[1.0.x → main] Move every pinned action to Node 24 (#5341) - #5348
Draft
thunder-automation-bot wants to merge 1 commit into
Draft
thunder-automation-bot wants to merge 1 commit into
thunder-automation-bot wants to merge 1 commit into
Conversation
Signed-off-by: Osara-B <osara922@gmail.com>
|
👋 @Osara-B @rajithacharith please review this forward-port of #5341 to
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated forward-port of #5341 from
1.0.xtomain.Original PR: #5341
Commits cherry-picked: 1
Source branch:
1.0.xTarget branch:
mainPurpose
Node 20 is removed from the GitHub Actions runners on 23 September 2026. Every action pinned in this repository still targeted it, so every job logged a deprecation warning.
actions/setup-gohas never cached anything in this repository: it looks forgo.sumat the repository root, which does not exist here, so every Go job loggedRestore cache failed: Dependencies file is not foundand re-downloaded its modules from scratch.This is the
1.0.xcounterpart of the same change onmain. It is needed separately because local composite actions are read from the checked-out branch, so a release cut from1.0.xwould otherwise load the old pins, and would get no Go cache at all now thatmain's release builder no longer carries the hand-rolled cache steps.Approach
Re-pinned 121
uses:lines to releases whose ownaction.ymldeclaresnode24, verified by fetchingaction.ymlat each pinned SHA. The two duplicateactions/cachepins were collapsed onto one.Set
cache-dependency-path: "**/go.sum"on.github/actions/setup-goso the built-in cache keys off all three Go modules instead of a root file that does not exist. Since setup-go now cachesGOMODCACHEandGOCACHEitself, the ten hand-rolledCache Go Modulessteps became duplicates and were removed, acrosspr-builder.yml(3),release-builder.yml(3),postgres-tests.yml(2),nightly-build-validation.yml(1) andwindows-powershell-validation.yml(1). The same setting was applied to the threesetup-gocalls inwindows-build-validation.ymlthat bypass the composite.Local composite actions are read from the checked-out tree, not the dispatch ref, so this only takes effect on branches containing it.
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks