str_like case sensitivity

NEWS.md

@@ -1,5 +1,6 @@
 # dbplyr (development version)
 
+* Corrected translation of `stringr::str_like()` to use case-sensitive `LIKE` when argument `ignore_case` is set as `FALSE` (@edward-burn, #1488).
 * Fixed overwrite flag in `copy_to()` to work when source is in the same DB as destination (@liudvikasakelis, #1535)
 * Snowflake correctly translates `$` to `:` (@jsowder, #1608)
 * `dbplyr_uncount()` now works with Redshift (@owenjonesuob, #1601).

R/backend-.R

@@ -284,12 +284,16 @@ base_scalar <- sql_translator(
   str_trim = sql_str_trim,
   str_c = sql_paste(""),
   str_sub = sql_str_sub("SUBSTR"),
-  str_like = function(string, pattern, ignore_case = TRUE) {
-    check_bool(ignore_case)
+  # https://docs.getdbt.com/sql-reference/like is typically case sensitive (#1490)
+  str_like = function(string, pattern, ignore_case = FALSE) {
     if (isTRUE(ignore_case)) {
-      sql_expr(!!string %LIKE% !!pattern)
+      cli_abort(c(
+        "Backend does not support case insensitive {.fn str_like}.",
+        i = "Set {.code ignore_case = FALSE} for case sensitive match.",
+        i = "Use {.fn tolower} on both arguments to achieve a case insensitive match."
+      ))
     } else {
-      cli::cli_abort("Backend only supports case insensitve {.fn str_like}.")
+      sql_expr(!!string %LIKE% !!pattern)
     }
   },
 

tests/testthat/_snaps/backend-.md

@@ -47,13 +47,15 @@
       Error in `x$id`:
       ! $ operator is invalid for atomic vectors
 
-# can translate case insensitive like
+# can only translate case sensitive str_like
 
     Code
-      test_translate_sql(str_like(x, "abc", ignore_case = FALSE))
+      test_translate_sql(str_like(x, "abc", ignore_case = TRUE))
     Condition
       Error in `str_like()`:
-      ! Backend only supports case insensitve `str_like()`.
+      ! Backend does not support case insensitive `str_like()`.
+      i Set `ignore_case = FALSE` for case sensitive match.
+      i Use `tolower()` on both arguments to achieve a case insensitive match.
 
 # default raw escapes translated correctly
 

tests/testthat/test-backend-.R

@@ -110,11 +110,18 @@ test_that("lead and lag translate n to integers", {
 
 # strings -----------------------------------------------------------------
 
-test_that("can translate case insensitive like", {
+test_that("can only translate case sensitive str_like", {
   local_con(simulate_dbi())
-  test_translate_sql(str_like(x, "abc"))
-  expect_snapshot(
+  expect_equal(
     test_translate_sql(str_like(x, "abc", ignore_case = FALSE)),
+    sql("`x` LIKE 'abc'")
+  )
+  expect_equal(
+    test_translate_sql(str_like(x, "ABC", ignore_case = FALSE)),
+    sql("`x` LIKE 'ABC'")
+  )
+  expect_snapshot(
+    test_translate_sql(str_like(x, "abc", ignore_case = TRUE)),
     error = TRUE
   )
 })