fix(fatfs): use Arc for struct FileSystem reference in struct File, struct Dir, etc #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Imai <[email protected]>
Koichi98
changed the title
veqcc
reviewed
Jun 18, 2025
Signed-off-by: Koichi <[email protected]>
veqcc
approved these changes
Jun 19, 2025
ytakano
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since fatfs is originally implemented for single thread application, structures that appear in fatfs source code directly hold the reference of its struct FileSystem. Because of this, it is difficult to use those structures in the source code that we cannot statically define the life time.
To solve this, we just have to introduce Arc so that the validity of this reference is checked dynamically.
This is partial PR of the implementation in PR #511. Please refer to #511 to see the overall description of these PRs.
Related links
#511
How was this PR tested?
Notes for reviewers