feat(filesystem): add async filesystem trait #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
veqcc
reviewed
Jun 26, 2025
Signed-off-by: Koichi <[email protected]>
veqcc
approved these changes
Jun 26, 2025
Signed-off-by: Koichi <[email protected]>
ytakano
reviewed
Jun 26, 2025
ytakano
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide async filesystem trait for no_std environment.
Since async Read, Write, Seek trait cannot be used in no_std environment, I've defined these traits myself in this file: AsyncSeekAndRead, AsyncSeekAndWrite. This may be replaced with embedded_io_async::{Read, Write, Seek} traits but since there will be a lot to fix, and since embedded-io-async doesn't seem stable yet, I've defined these myself for now. (I've already tried using embedded_io_async and it seems working. It will be merged in the near future.)
Related links
PR #511
How was this PR tested?
Notes for reviewers