feat(virtio): support multicast and CTRL_VQ #662
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main multicast implementation was inherited from that pull request and I’m committing it as Co-authored.
#592
For CTRL_VQ, Awkernel currently accepts every packet. This causes issues such as
https://github.com/tier4/awkernel/blob/main/awkernel_drivers/src/pcie/virtio/virtio_net.rs#L1113
Because, CTRL_VQ is unimplemented we fall back to ALLMULTI | PROMISC
So multicast traffic(mDNS)that we never joined also enters the RX ring. The upper session_types layer assumes “only frames I should process will arrive” and blindly unwraps, so unexpected frames surface as Err(EtherFrameBuf) and crash.
https://github.com/tier4/awkernel/blob/main/awkernel_drivers/src/pcie/virtio/virtio_net.rs#L481
This issue. We know this crash is triggered by the burst of mDNS packets emitted when a tap or bridge is created and brought UP for the first time. I haven’t yet found a good reference for addressing this, so I’ll keep the issue open until we can implement it.
Related links
How was this PR tested?
Notes for reviewers