DSS-3113: Add ruff & sqlfluff to pre-commit #23
Draft
charlotte-a27 wants to merge 5 commits intomasterfrom
Draft
DSS-3113: Add ruff & sqlfluff to pre-commit #23charlotte-a27 wants to merge 5 commits intomasterfrom
charlotte-a27 wants to merge 5 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new pre-commit hooks for ruff and sqlfluff to improve code quality and SQL linting.
- Adds a ruff-pre-commit repository with a ruff hook to auto-fix issues.
- Adds a sqlfluff repository with sqlfluff-lint and sqlfluff-fix hooks.
Comments suppressed due to low confidence (1)
.pre-commit-config.yaml:23
- It appears that the flake8 hook is included in the sqlfluff repository block, which seems unintended. Please remove the flake8 hook and its related dependencies from this block if they are not meant for sqlfluff.
- id: flake8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.