docs: remove obsolete GGML_NATIVE workaround - #5590
Conversation
How this change flows0 changed behaviours across 4 relationships. 4 surrounding behaviours are shown (6 graph nodes walked). 7 further behaviours left out to keep the diagram readable. flowchart LR
n0["main"]:::impacted
n1["main"]:::impacted
n2["none"]:::impacted
n3["map_err"]:::impacted
n0 -->|calls| n2
n0 -->|calls| n3
n1 -->|calls| n2
n1 -->|calls| n3
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change removes the obsolete ChangesCommand guidance updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes obsolete build-workaround instructions from contributor documentation and examples without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
GGML_NATIVE=OFFprefix from active contributor-facing build and test commands.Problem
The bundled whisper.cpp STT engine and its
whisper-rsdependencies were removed, but the oldGGML_NATIVE=OFFworkaround remained in current documentation and examples. New contributors and agents could copy an obsolete platform-specific command into otherwise valid workflows.Solution
This documentation-only patch removes the obsolete prefix from
AGENTS.md,docs/library-minimal-recipe.md,docs/library-benchmarking.md,examples/embed_headless.rs, andexamples/embed_kernel.rs. Historical plans and specifications are intentionally left unchanged because they describe past implementation states.Submission Checklist
Closes #5461in the Related section.Impact
No runtime, platform, security, migration, or compatibility behavior changes. The patch only makes current contributor and example commands accurate.
Related
AI Authored PR Metadata
Linear Issue
Commit & Branch
docs/drop-obsolete-ggml-prefix6bb1bbabeValidation Run
pnpm --filter openhuman-app format:check: blocked — dependencies are not installed in the sandbox (node_modulesabsent).pnpm typecheck: N/A — documentation-only change.Validation Blocked
pnpm format:checknode_modulesis absent.git diff --checkpasses, and the obsolete prefix is absent from the active issue-scoped files.Behavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit
GGML_NATIVE=OFFworkaround.