test: remove stale meet settings RPC references from e2e tests - #5679
Conversation
The meet settings RPC calls and their associated assertions have been removed from two end-to-end test files, as the meet settings feature is no longer supported. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe E2E tests remove Meet settings schema and round-trip coverage. Localized README files remove subconscious and meeting-agent feature entries. ChangesObsolete feature removal
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes obsolete meet-settings test calls and dead localized documentation links without changing product behavior; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ized readmes Remove two feature descriptions from the German, Japanese, Korean, Urdu, and Chinese readme files: the "subconscious" background loop and the "meeting agents" that join video calls. These features are no longer part of the product and the links were broken, so the entries are deleted to keep the documentation accurate. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Summary
meet/meet_agentdomains (config_get_meet_settings/config_update_meet_settings) and thesubconscious/meeting-agentsgitbook feature pages, but was merged before two integration tests and the localized READMEs were cleaned up.tests/config_auth_app_state_connectivity_e2e.rsandtests/domain_modules_e2e.rs(restores the schema-catalog expected list to match the runtime and deletes the dead meet-settings code in the runtime-flags round-trip test).subconscious,Meeting-Agenten/meeting agents) from the five translateddocs/README.{de,ja-JP,ko,ur-pk,zh-CN}.mdfiles, whose gitbook links now 404.Problem
#5674 merged before two follow-ups were in place, leaving
mainwith:Rust Core Coverage (cargo-llvm-cov)failing:config_runtime_flags_settings_readbacks_and_validation_paths_are_exercisedpanics withunknown method: openhuman.config_update_meet_settings, andworker_a_controller_schemas_are_fully_exposedfails its schema-catalog assertion (expected list still names the removed meet methods).tests/domain_modules_e2e.rscarries the same two calls.Markdown Link Checkfailing: the five translated READMEs link to the removedfeatures/subconsciousandfeatures/mascot/meeting-agentsgitbook pages (404).Solution
config_auth_app_state_connectivity_e2e.rs: dropconfig_get_meet_settings/config_update_meet_settingsfrom theworker_a_controller_schemas_are_fully_exposedexpected list (keepingconfig_update_memory_settings, which still exists); delete the dead meet-settings update/get/assert block.domain_modules_e2e.rs: delete the same dead meet-settings block.docs/README.{de,ja-JP,ko,ur-pk,zh-CN}.md: remove thesubconsciousand meeting-agent bullet items for the removed features.Submission Checklist
## RelatedRelated
Summary by CodeRabbit