Skip to content

test: remove stale meet settings RPC references from e2e tests - #5679

Merged
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:fix-pr5674-broken-tests
Aug 22, 2026
Merged

test: remove stale meet settings RPC references from e2e tests#5679
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:fix-pr5674-broken-tests

Conversation

@senamakel

@senamakel senamakel commented Aug 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Follow-up to chore: remove desktop companion, AgentBox, meetings and the subconscious loop #5674, which removed the meet/meet_agent domains (config_get_meet_settings / config_update_meet_settings) and the subconscious/meeting-agents gitbook feature pages, but was merged before two integration tests and the localized READMEs were cleaned up.
  • Removes the now-dangling references to those two RPC methods from tests/config_auth_app_state_connectivity_e2e.rs and tests/domain_modules_e2e.rs (restores the schema-catalog expected list to match the runtime and deletes the dead meet-settings code in the runtime-flags round-trip test).
  • Removes the two obsolete localized feature bullets (subconscious, Meeting-Agenten/meeting agents) from the five translated docs/README.{de,ja-JP,ko,ur-pk,zh-CN}.md files, whose gitbook links now 404.

Problem

#5674 merged before two follow-ups were in place, leaving main with:

  • Rust Core Coverage (cargo-llvm-cov) failing: config_runtime_flags_settings_readbacks_and_validation_paths_are_exercised panics with unknown method: openhuman.config_update_meet_settings, and worker_a_controller_schemas_are_fully_exposed fails its schema-catalog assertion (expected list still names the removed meet methods). tests/domain_modules_e2e.rs carries the same two calls.
  • Markdown Link Check failing: the five translated READMEs link to the removed features/subconscious and features/mascot/meeting-agents gitbook pages (404).

Solution

  • config_auth_app_state_connectivity_e2e.rs: drop config_get_meet_settings / config_update_meet_settings from the worker_a_controller_schemas_are_fully_exposed expected list (keeping config_update_memory_settings, which still exists); delete the dead meet-settings update/get/assert block.
  • domain_modules_e2e.rs: delete the same dead meet-settings block.
  • docs/README.{de,ja-JP,ko,ur-pk,zh-CN}.md: remove the subconscious and meeting-agent bullet items for the removed features.

Submission Checklist

Remaining items checked via the checklist parser.

  • Tests added or updated — test-only fixes; the two integration tests now compile and pass against the meet-free runtime schema.
  • Diff coverage ≥ 80% — deletions only.
  • Coverage matrix updated — N/A, test-only fix, no feature rows changed.
  • All affected feature IDs listed under ## Related
  • No new external network dependencies
  • Manual smoke checklist updated — N/A, test-only change; no release-cut surface touched.
  • Linked issue closed — fixes the regression and dead links left by chore: remove desktop companion, AgentBox, meetings and the subconscious loop #5674.

Related

Summary by CodeRabbit

  • Tests
    • Removed end-to-end coverage for updating and retrieving Meet settings.
    • Updated configuration schema validation to no longer expect Meet settings operations.
  • Documentation
    • Removed references to Subconscious background loops and Meeting Agents from the German, Japanese, Korean, Urdu, and Simplified Chinese documentation.
    • Updated feature listings to keep translated documentation aligned with the currently available product capabilities.

The meet settings RPC calls and their associated assertions have been removed from two end-to-end test files, as the meet settings feature is no longer supported.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel requested a review from a team August 22, 2026 10:13
@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 22, 2026

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 135 embedded · openrouter/openai/text-embedding-3-small

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f48b66db-70de-4637-bd4e-66515bb99ad6

📥 Commits

Reviewing files that changed from the base of the PR and between 5f58eda and b1cb1b2.

📒 Files selected for processing (5)
  • docs/README.de.md
  • docs/README.ja-JP.md
  • docs/README.ko.md
  • docs/README.ur-pk.md
  • docs/README.zh-CN.md
💤 Files with no reviewable changes (5)
  • docs/README.de.md
  • docs/README.ja-JP.md
  • docs/README.ko.md
  • docs/README.zh-CN.md
  • docs/README.ur-pk.md

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The E2E tests remove Meet settings schema and round-trip coverage. Localized README files remove subconscious and meeting-agent feature entries.

Changes

Obsolete feature removal

Layer / File(s) Summary
Remove Meet settings coverage
tests/config_auth_app_state_connectivity_e2e.rs, tests/domain_modules_e2e.rs
The tests no longer list or exercise config_get_meet_settings and config_update_meet_settings.
Remove localized feature entries
docs/README.de.md, docs/README.ja-JP.md, docs/README.ur-pk.md
The README files no longer describe subconscious and meeting-agent features.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b1cb1

This change removes obsolete meet-settings test calls and dead localized documentation links without changing product behavior; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit checked the test suite today,
Old Meet settings hopped away.
Feature notes were trimmed with care,
Across three tongues, they’re no longer there.
The files now match the current display.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: removing stale Meet settings RPC references from end-to-end tests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 22, 2026
…ized readmes

Remove two feature descriptions from the German, Japanese, Korean, Urdu, and Chinese readme files: the "subconscious" background loop and the "meeting agents" that join video calls. These features are no longer part of the product and the links were broken, so the entries are deleted to keep the documentation accurate.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel merged commit 3118583 into tinyhumansai:main Aug 22, 2026
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant