test: drop meet-settings expectations left behind by the meetings removal - #5681
Conversation
Removed the meet settings RPC calls and their expected schema entries from the end-to-end test, as the meet settings feature has been deprecated and is no longer part of the configuration API. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Removed the config_meet_settings round-trip test from the domain modules end-to-end test suite because the meet settings feature has been deprecated and is no longer supported by the application. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe changes remove meet-settings JSON-RPC round-trip assertions from end-to-end tests. Other configuration and domain-module coverage remains unchanged. ChangesMeet settings test coverage
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This test-only cleanup removes expectations for RPCs that were intentionally removed; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed an unnecessary blank line from the end-to-end test file to improve code formatting consistency. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
How this change flows1 changed behaviour across 9 relationships. 5 surrounding behaviours are shown (60 graph nodes walked). 53 further behaviours left out to keep the diagram readable. flowchart LR
n0["...er_a_controller_schemas_are_fully_exposed<br/>changed"]:::changed
n1["join"]:::impacted
n2["expect"]:::impacted
n3["env_lock"]:::impacted
n4["setup"]:::impacted
n5["vec"]:::impacted
n0 -->|calls| n3
n0 -->|calls| n4
n0 -->|calls| n5
n0 -->|tests| n5
n4 -->|calls| n1
n4 -->|tests| n1
n4 -->|calls| n2
n4 -->|calls| n5
n4 -->|tests| n5
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge. |
What
Removes the
config_get_meet_settings/config_update_meet_settingsexpectations from two integration tests:tests/config_auth_app_state_connectivity_e2e.rs— two entries in theconfigschema-catalog list, and the settings round-trip inconfig_runtime_flags_settings_readbacks_and_validation_paths_are_exercisedtests/domain_modules_e2e.rs— the equivalent round-trip block47 deletions, tests only. No source change.
Why
mainis currently red onRust Core Coverage (cargo-llvm-cov).#5674 removed the meetings domain, which unregistered the two
config_*_meet_settingsRPC methods, but the tests still expect them:So two tests fail on
main:Because this is on
main, it fails on every PR that merges it — it is currently the soleRust Core Coveragefailure on #5664, #5668, #5670 and #5671, none of which touch meet settings. Deleting the expectations is the correct fix: the methods are intentionally gone, so there is nothing to assert.Verification
Summary by CodeRabbit