Skip to content

test: drop meet-settings expectations left behind by the meetings removal - #5681

Merged
senamakel merged 3 commits into
tinyhumansai:mainfrom
senamakel:fix-meet-test-drift
Aug 22, 2026
Merged

test: drop meet-settings expectations left behind by the meetings removal#5681
senamakel merged 3 commits into
tinyhumansai:mainfrom
senamakel:fix-meet-test-drift

Conversation

@senamakel

@senamakel senamakel commented Aug 22, 2026

Copy link
Copy Markdown
Member

What

Removes the config_get_meet_settings / config_update_meet_settings expectations from two integration tests:

  • tests/config_auth_app_state_connectivity_e2e.rs — two entries in the config schema-catalog list, and the settings round-trip in config_runtime_flags_settings_readbacks_and_validation_paths_are_exercised
  • tests/domain_modules_e2e.rs — the equivalent round-trip block

47 deletions, tests only. No source change.

Why

main is currently red on Rust Core Coverage (cargo-llvm-cov).

#5674 removed the meetings domain, which unregistered the two config_*_meet_settings RPC methods, but the tests still expect them:

$ git grep -l config_update_meet_settings src/     # nothing
$ git grep -l config_update_meet_settings tests/   # two files

So two tests fail on main:

config_runtime_flags_settings_readbacks_and_validation_paths_are_exercised
  → update_meet_settings true: unexpected JSON-RPC error:
    {"code":-32000,"message":"unknown method: openhuman.config_update_meet_settings"}

worker_a_controller_schemas_are_fully_exposed
  → assertion `left == right` failed: schema catalog mismatch for namespace config

Because this is on main, it fails on every PR that merges it — it is currently the sole Rust Core Coverage failure on #5664, #5668, #5670 and #5671, none of which touch meet settings. Deleting the expectations is the correct fix: the methods are intentionally gone, so there is nothing to assert.

Verification

$ git grep -c meet_settings tests/
0
$ cargo check --tests --features "$(bash scripts/ci/product-features.sh)" \
    --test config_auth_app_state_connectivity_e2e --test domain_modules_e2e
Finished `dev` profile in 2m 25s

Summary by CodeRabbit

  • Tests
    • Updated end-to-end test coverage by removing checks for retrieving and updating meeting settings.
    • Removed associated schema validation and round-trip assertions.
    • Continued coverage for analytics, dictation, search, profiles, tools, threads, and other domain functionality.
    • No user-facing product behavior changes are included in this update.

senamakel and others added 2 commits August 22, 2026 14:46
Removed the meet settings RPC calls and their expected schema entries from the end-to-end test, as the meet settings feature has been deprecated and is no longer part of the configuration API.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Removed the config_meet_settings round-trip test from the domain modules end-to-end test suite because the meet settings feature has been deprecated and is no longer supported by the application.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel requested a review from a team August 22, 2026 11:49
@senamakel senamakel self-assigned this Aug 22, 2026
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 04070095-b738-4886-a8fd-33b5b65bf868

📥 Commits

Reviewing files that changed from the base of the PR and between ce01676 and 1cec09e.

📒 Files selected for processing (1)
  • tests/config_auth_app_state_connectivity_e2e.rs
💤 Files with no reviewable changes (1)
  • tests/config_auth_app_state_connectivity_e2e.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The changes remove meet-settings JSON-RPC round-trip assertions from end-to-end tests. Other configuration and domain-module coverage remains unchanged.

Changes

Meet settings test coverage

Layer / File(s) Summary
Remove meet-settings E2E assertions
tests/config_auth_app_state_connectivity_e2e.rs, tests/domain_modules_e2e.rs
The tests no longer validate the meet-settings update and retrieval flow or the auto_orchestrator_handoff round trip.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 1cec0

This test-only cleanup removes expectations for RPCs that were intentionally removed; no actionable merge-blocking risk remains after normal checks and review.

Poem

I’m a rabbit with tests in my den,
I removed old checks from the test pen.
Meet settings hop away,
Remaining checks stay.
Thump, thump—clean tests again!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes removing obsolete meet-settings test expectations after the meetings domain removal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 22, 2026
@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 22, 2026

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 134 embedded · openrouter/openai/text-embedding-3-small

Removed an unnecessary blank line from the end-to-end test file to improve code formatting consistency.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Aug 22, 2026

Copy link
Copy Markdown

How this change flows

1 changed behaviour across 9 relationships. 5 surrounding behaviours are shown (60 graph nodes walked). 53 further behaviours left out to keep the diagram readable.

flowchart LR
  n0["...er_a_controller_schemas_are_fully_exposed<br/>changed"]:::changed
  n1["join"]:::impacted
  n2["expect"]:::impacted
  n3["env_lock"]:::impacted
  n4["setup"]:::impacted
  n5["vec"]:::impacted
  n0 -->|calls| n3
  n0 -->|calls| n4
  n0 -->|calls| n5
  n0 -->|tests| n5
  n4 -->|calls| n1
  n4 -->|tests| n1
  n4 -->|calls| n2
  n4 -->|calls| n5
  n4 -->|tests| n5
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading

Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge.

tinysweeper 0.1.0

@senamakel
senamakel merged commit 3e8533c into tinyhumansai:main Aug 22, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant