Skip to content

test: drop the stale '## Memory context' assertion left by the reflection-section removal - #5684

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:fix-reflection-context-drift
Aug 22, 2026
Merged

test: drop the stale '## Memory context' assertion left by the reflection-section removal#5684
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:fix-reflection-context-drift

Conversation

@senamakel

@senamakel senamakel commented Aug 22, 2026

Copy link
Copy Markdown
Member

What

Removes one stale assertion from prompt_renderers_cover_user_memory_identity_tools_and_subagent_variants in tests/raw_coverage/agent_round26_raw_coverage_e2e.rs:

assert!(built.contains("## Memory context"));

One line, tests only.

Why

main is red on Rust Core Coverage (cargo-llvm-cov):

panicked at tests/raw_coverage/agent_round26_raw_coverage_e2e.rs:305:5:
assertion failed: built.contains("## Memory context")

a6749d8e6 ("chore(agent): remove unused ReflectionMemoryContextSection") removed the section that emitted this header, so no built prompt contains it any more:

$ git grep -c '## Memory context' src/     # nothing

8237942d6 ("fix(tests): remove reflection context from raw coverage e2e test") was the cleanup for that removal, but it missed this occurrence.

Because it is on main, it fails on every PR whose changed-module set reaches this test — it is currently the sole Rust Core Coverage failure on #5670, which touches only gateway, i18n, store and utils code and nothing to do with prompt rendering.

Deliberately NOT changed

Three other tests assert "[Memory context]" — a different string, bracketed rather than a Markdown heading:

  • tests/raw_coverage/channels_large_round25_raw_coverage_e2e.rs:361
  • tests/raw_coverage/channels_lark_email_dispatch_round21_raw_coverage_e2e.rs:253
  • tests/raw_coverage/channels_provider_deep_raw_coverage_e2e.rs:171

That block is still emitted, by src/openhuman/agent/harness/memory_context.rs:66, so those assertions are correct and are left alone. A blanket grep-and-delete on "Memory context" would have removed live coverage.

Verification

$ cargo test --features "$(bash scripts/ci/product-features.sh)" \
    --test raw_coverage_all 'agent_round26_raw_coverage_e2e::' -- --test-threads=1
test agent_round26_raw_coverage_e2e::prompt_renderers_cover_user_memory_identity_tools_and_subagent_variants ... ok
test result: ok. 3 passed; 0 failed; 469 filtered out

$ cargo fmt --check    # clean

Summary by CodeRabbit

  • Tests
    • Updated automated prompt-rendering checks to reflect the current output format.
    • Continued validation of user memory details, project summaries, and available tool information.
    • No user-facing behavior changes are included in this update.

Removed an assertion that checked for the "## Memory context" header in the prompt renderer test, as this header is no longer present in the rendered output after a change to the memory context section.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel requested a review from a team August 22, 2026 17:46
@senamakel senamakel self-assigned this Aug 22, 2026
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f9cd85af-3e28-42d6-bc34-e451b098307b

📥 Commits

Reviewing files that changed from the base of the PR and between 5221120 and a34342c.

📒 Files selected for processing (1)
  • tests/raw_coverage/agent_round26_raw_coverage_e2e.rs
💤 Files with no reviewable changes (1)
  • tests/raw_coverage/agent_round26_raw_coverage_e2e.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The prompt-renderer test removes the assertion for ## Memory context. Assertions for user memory, the memory summary, and tool signatures remain unchanged.

Changes

Prompt renderer test

Layer / File(s) Summary
Remove obsolete memory header check
tests/raw_coverage/agent_round26_raw_coverage_e2e.rs
The test no longer asserts that the built system prompt contains ## Memory context. Other prompt assertions remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a3434

This test-only change removes an assertion for a header that no longer exists; it does not alter product behavior or runtime code, and no actionable merge-blocking risk remains after normal checks.

Poem

I’m a rabbit with a prompt to inspect,
One old header hopped off the checklist.
User Memory stays, tools still align,
The summary remains right on time.
Squeak, test green, the change is precise!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the removal of the stale assertion, which is the sole change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 22, 2026

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 53 embedded · openrouter/openai/text-embedding-3-small

@senamakel
senamakel merged commit c79adfd into tinyhumansai:main Aug 22, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant