test: drop the stale '## Memory context' assertion left by the reflection-section removal - #5684
Conversation
Removed an assertion that checked for the "## Memory context" header in the prompt renderer test, as this header is no longer present in the rendered output after a change to the memory context section. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe prompt-renderer test removes the assertion for ChangesPrompt renderer test
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This test-only change removes an assertion for a header that no longer exists; it does not alter product behavior or runtime code, and no actionable merge-blocking risk remains after normal checks. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Removes one stale assertion from
prompt_renderers_cover_user_memory_identity_tools_and_subagent_variantsintests/raw_coverage/agent_round26_raw_coverage_e2e.rs:One line, tests only.
Why
mainis red onRust Core Coverage (cargo-llvm-cov):a6749d8e6("chore(agent): remove unused ReflectionMemoryContextSection") removed the section that emitted this header, so no built prompt contains it any more:8237942d6("fix(tests): remove reflection context from raw coverage e2e test") was the cleanup for that removal, but it missed this occurrence.Because it is on
main, it fails on every PR whose changed-module set reaches this test — it is currently the soleRust Core Coveragefailure on #5670, which touches only gateway, i18n, store and utils code and nothing to do with prompt rendering.Deliberately NOT changed
Three other tests assert
"[Memory context]"— a different string, bracketed rather than a Markdown heading:tests/raw_coverage/channels_large_round25_raw_coverage_e2e.rs:361tests/raw_coverage/channels_lark_email_dispatch_round21_raw_coverage_e2e.rs:253tests/raw_coverage/channels_provider_deep_raw_coverage_e2e.rs:171That block is still emitted, by
src/openhuman/agent/harness/memory_context.rs:66, so those assertions are correct and are left alone. A blanket grep-and-delete on "Memory context" would have removed live coverage.Verification
Summary by CodeRabbit