-
Notifications
You must be signed in to change notification settings - Fork 9
ci(release): skip crates.io package/publish while crates are unpublishable #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e1de5ab
ci(release): fail fast when CARGO_REGISTRY_TOKEN is missing
senamakel 77eaad8
chore(cargo): mark crate as unpublishable
senamakel 3bfd79f
chore(tinychannels-bus): add Cargo.toml for the new crate
senamakel 897263f
chore(ci): add release workflow
senamakel 8d0e630
fix(ci): update release workflow to use latest actions
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On every release run, the new
publish = falseflags make this comparison succeed, so the conditions on the package and publish steps skip both crates while the workflow still pushes the release commit and tag. The job therefore reports success and consumes a version without publishingtinychannels-busortinychannelsto crates.io, contrary to the existing release flow and README dependency instructions; keep these crates publishable and validate the registry token before creating the release commit instead. The repository structure identifies onlytinychannels-moduleas the private, unpublishable artifact crate.AGENTS.md reference: AGENTS.md:L8-L12
Useful? React with 👍 / 👎.