Skip to content

Conversation

@JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Sep 12, 2024

This PR adds a marketplace for file actions.

How it looks on mobile

Changelog

  • Add a description field to FileAction
    • Right now it's a CharField(max_length=100), it should be discussed whether a TextField or a CharField with a larger length limit is needed.
  • Add a view for managing file actions
    • Teachers can add and remove file actions from their course here.
    • Redirects to a new create/edit view
  • Add a create/edit view.
    • If ?copy=1 is passed, it will create a copy of a file action.
  • Changed file action parsing from self.command.split(" ") to shlex.split for more intuitive command behavior.
  • Changes css rule .btn.btn-ion to .btn-ion
    • It was confusing if .btn did anything, or if you were supposed to do .btn.tin-btn, etc.

TODO

  • CSS
  • "Marketplace" for courses
  • Views
  • Docs
  • Tests
  • Turn trash button into normal remove button
  • Improve copy file action

Closes #7

@JasonGrace2282 JasonGrace2282 self-assigned this Sep 12, 2024
@JasonGrace2282 JasonGrace2282 force-pushed the file-action branch 4 times, most recently from 10115b6 to d0451eb Compare October 18, 2024 02:24
@JasonGrace2282

This comment was marked as outdated.

@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review October 19, 2024 01:39
@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner October 19, 2024 01:39
@JasonGrace2282 JasonGrace2282 force-pushed the file-action branch 6 times, most recently from c05369e to 47acd1a Compare October 19, 2024 16:04
@JasonGrace2282 JasonGrace2282 added the complex PRs or issues requiring substantial effort to implement and/or review label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complex PRs or issues requiring substantial effort to implement and/or review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement file actions management

2 participants