Conversation
Added unit tests and integration tests for ProgressThrottler
juaninf
reviewed
Apr 4, 2026
Contributor
juaninf
left a comment
juaninf
left a comment
There was a problem hiding this comment.
Seems ProgressThrottler is added as a standalone utility class but it is not integrated into BulkScanWorker, which seems is the natural way where it should be. BulkScanWorker already has the progressConsumer pipeline in handle(). Putting it with the throttler here would make throttled partial result persistence a built-in framework feature rather than something each subclass has to wire up manually.
Author
|
ProgressThrottler is now integrated into BulkScanWorker.handle(), which wraps the progressConsumer with throttling before passing it to scan(). |
Throttled partial result publishing is now a built-in framework feature BulkScanWorker.handle() wraps the progressConsumer transparently. Config (partialResultsEnabled, partialResultThrottleMs) added to ScanConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ProgressThrottler, a generic throttler for progress updates during scans. Ensures updates are published at most once per configurable time window