Move parallelProbes from worker config to ScanConfig#72
Open
Move parallelProbes from worker config to ScanConfig#72
Conversation
XoMEX
requested changes
Apr 15, 2026
Comment on lines
+249
to
+250
| ScanConfig scanConfig = getScanConfig(); | ||
| scanConfig.setParallelProbes(getParallelProbes()); |
Member
There was a problem hiding this comment.
Inconsistent with how we set the other parameters.
Comment on lines
+157
to
+159
| if (scanJobDescription.getBulkScanInfo().getScanConfig().getParallelProbes() <= 0) { | ||
| scanJobDescription.getBulkScanInfo().getScanConfig().setParallelProbes(1); | ||
| } |
|
|
||
| private int timeout; | ||
|
|
||
| private int parallelProbes = 1; |
Member
There was a problem hiding this comment.
Why does this have a default value?
| */ | ||
| protected ScanConfig(ScannerDetail scannerDetail, int reexecutions, int timeout) { | ||
| this(scannerDetail, reexecutions, timeout, null); | ||
| this(scannerDetail, reexecutions, timeout, 1, null); |
Member
There was a problem hiding this comment.
Handle it like the other ones: Expect it as an argument.
(Maybe we want to change to a builder pattern at some point)
Comment on lines
+61
to
72
| protected ScanConfig( | ||
| ScannerDetail scannerDetail, | ||
| int reexecutions, | ||
| int timeout, | ||
| int parallelProbes, | ||
| List<ProbeType> excludedProbes) { | ||
| this.scannerDetail = scannerDetail; | ||
| this.reexecutions = reexecutions; | ||
| this.timeout = timeout; | ||
| this.parallelProbes = parallelProbes; | ||
| this.excludedProbes = excludedProbes; | ||
| } |
Member
There was a problem hiding this comment.
Just keep this constructor. Yes it is a breaking change, but the only "user" is TLS-Crawler (and maybe SSH Crawler)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
parallelProbes, introduced in #69, from worker configuration to scan configuration:parallelProbesto controller-side scan creation (ControllerCommandConfig->ScanConfig).-parallelProbesfromWorkerCommandConfig.parallelProbesfrom job scan config, with fallback to1for invalid values.