fix: eliminate pane_contents cleanup race that errors on fish/slow-shell restore - #580
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate pane_contents cleanup race that errors on fish/slow-shell restore.
Why this matters
On restore, tmux-resurrect prints
cat: '.../restore/pane_contents//pane-<id>': No such file or directoryat the top of the screen even though the session restores. A second reporter confirms it hits ~2 of 6 panes non-deterministically, that the missing files ARE present inside thepane_contents.tar.gzarchive, and that it correlates with fish shell - concluding "the extracted contents might have been cleaned up before these panes were fully restored." Both reporters use fish. This is a race condition, not missing data.Testing
Changes are scoped to the files named in the fix; added or updated tests where the project has a suite, and matched existing conventions.
Fixes #538