Skip to content

Conversation

@adamsch1
Copy link

@adamsch1 adamsch1 commented Nov 5, 2025

This is an idea


Note

Introduces a new overlay volume type enabling qcow2 copy-on-write disks with PVC/HostPath backing and optional persistent targets, with full validation, rendering, conversion, creation, and cleanup paths.

  • API:
    • Add v1.OverlayVolumeSource to VolumeSource with backing (backingPVC/backingHostPath), target (targetPVC/targetHostPath), backingFormat, and persistent.
    • Update OpenAPI/Swagger, deepcopy, client-go openapi, validations, and API testdata.
  • Validation:
    • Extend VMI create admitter to validate overlay backing/target exclusivity, persistent rules, PVC/HostPath fields, and backingFormat (raw|qcow2).
  • Controller (virt-controller):
    • Render overlay volumes: mount backing-<vol> and optional target-<vol> via PVC or HostPath.
  • Launcher (virt-launcher):
    • Converter: map overlay to libvirt XML with qcow2 source and proper backingStore (file/block, format).
    • Manager: create overlay images via new handler during domain setup.
  • Ephemeral Disk:
    • Add overlay-disk-handler to create overlay images and cleanup non-persistent overlays; tests added.
    • Make image creation idempotent in CreateBackedImageForVolume.
  • virt-handler:
    • Cleanup non-persistent overlay files on VMI teardown (best-effort).
  • Docs:
    • Add OVERLAY_VOLUMES.md and OVERLAY_VOLUME_STATES.md with usage and state matrix.

Written by Cursor Bugbot for commit d75455f. This will update automatically on new commits. Configure here.

@adamsch1 adamsch1 requested review from Yarosh and eb3095 November 5, 2025 22:04
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 7

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants