fix(subscriber): make Layered propagate on_register_dispatch #3379
+182
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It seems like this was overlooked in #2269 |
This was referenced Sep 29, 2025
bantonsson
force-pushed
the
ban/make-layered-propagate-on-register-dispatch
branch
from
b8ddabe to
a86f408
Compare
hds
requested changes
Nov 20, 2025
Contributor
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Thanks for your PR! I've got a couple of comments.
| } | ||
| } | ||
|
|
||
| impl Subscriber for TestLayer { |
Contributor
There was a problem hiding this comment.
What do you think about extending the MockSubscriebr and MockLayer in tracing-mock to allow expecting on_register_dispatch?
| S: Subscriber, | ||
| { | ||
| fn on_register_dispatch(&self, subscriber: &Dispatch) { | ||
| self.layer.on_register_dispatch(subscriber); |
Contributor
There was a problem hiding this comment.
I think we probably want to switch the order here, so that the actual subscriber gets the chance to register first.
hds
added
kind/bug
bantonsson
force-pushed
the
ban/make-layered-propagate-on-register-dispatch
branch
from
a86f408 to
77aedec
Compare
hds
reviewed
Nov 21, 2025
Contributor
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Looking great. Thank you! I've got one Question.
| /// [`tracing::subscriber::set_global_default`], so explicitly expecting | ||
| /// this is not usually necessary. However, it may be useful when testing | ||
| /// custom layer implementations that manually call `on_register_dispatch`. | ||
| /// |
Contributor
There was a problem hiding this comment.
Is it possible to add a negative case here?
If not (or not easily) that's fine. Thank you for enhancing tracing-mock!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
Layeredimplementation ofSubscriberdoes not implement and propagate theon_register_dispatchcallback. This means that combined layers will never have theiron_register_dispatchmethods called.Solution
Implement the missing
on_register_dispatchmethod.