Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser assertions can confuse rendered text with control names, miss a state change that occurs just after lookup, or match text behind a dialog.
presses Entercan also open a dialog and immediately activate its newly focused close button because a separate synthetic character event bypasses the prevented keydown.Named-role assertions use computed accessibility roles/names, require unique visible matches and scope content/field values to that element. Existing page-wide text assertions retain their semantics. State assertions also follow labels to their controls when the visible label is transformed by CSS. No element handles are cached across retries or navigation.
Documentation explains assertion intent, bounded waits, redundant readiness checks and measuring setup/reset/scenario costs. Generated step documentation and native integration scenarios cover every new step.
Evidence
After: those regressions pass, including Enter/Space, prevented printable keys, replacement controls, uppercase labels, implicit roles, hidden/ambiguous duplicates, background-text exclusion, field values and dialog disappearance.
go test -short ./...,go test ./command ./internal/resource/browser, focused browser regressions with-race,go build ./...,go vet ./internal/resource/browser, andgit diff --check.Merge Danger
Door: two-way
Reversible implementation and additive step syntax; no existing text step changes meaning.
Blast Radius: browser
Keyboard dispatch changes all
pressesactions. Enabled/disabled assertions now wait for the expected state, so an incorrect state can take the configured timeout to fail. Successful conditions return immediately.